On Mon, Dec 06, 2021 at 10:38:07AM +0100, Geert Uytterhoeven wrote: > Hi Gabriel, > > On Sat, Dec 4, 2021 at 12:42 AM Gabriel Somlo <gsomlo@xxxxxxxxx> wrote: > > LiteSDCard is a small footprint, configurable SDCard core for FPGA > > based system on chips. > > > > Signed-off-by: Gabriel Somlo <gsomlo@xxxxxxxxx> > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/litex,mmc.yaml > > @@ -0,0 +1,63 @@ > > +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mmc/litex,mmc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LiteX LiteSDCard device > > + > > +maintainers: > > + - Gabriel Somlo <gsomlo@xxxxxxxxx> > > + > > +description: | > > + LiteSDCard is a small footprint, configurable SDCard core for FPGA based > > + system on chips. > > + > > + The hardware source is Open Source and can be found on at > > + https://github.com/enjoy-digital/litesdcard/. > > + > > +allOf: > > + - $ref: mmc-controller.yaml# > > + > > +properties: > > + compatible: > > + const: litex,mmc > > + > > + reg: > > + items: > > + - description: PHY registers > > + - description: CORE registers > > + - description: DMA Reader buffer > > + - description: DMA Writer buffer > > + - description: IRQ registers > > + > > + reg-names: > > + items: > > + - const: phy > > + - const: core > > + - const: reader > > + - const: writer > > + - const: irq > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > reg-names? > > (and updating litex/tools/litex_json2dts_linux.py to add it) Thanks, I missed `reg-names` originally, and have added it to the list. And yes, once we agree on all this, I'll submit a matching update to litex_json2dts_linux.py Thanks, --Gabriel > > + - interrupts > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + mmc: mmc@12005000 { > > + compatible = "litex,mmc"; > > + reg = <0x12005000 0x100>, > > + <0x12003800 0x100>, > > + <0x12003000 0x100>, > > + <0x12004800 0x100>, > > + <0x12004000 0x100>; > > + reg-names = "phy", "core", "reader", "writer", "irq"; > > + interrupts = <4>; > > + }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds