Re: [PATCH 1/2] pinctrl: bcm2835: Change init order for gpio hogs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 01/12/2021 16:25, Andy Shevchenko wrote:
On Wed, Dec 1, 2021 at 6:08 PM Phil Elwell <phil@xxxxxxxxxxxxxxx> wrote:
On 01/12/2021 15:38, Andy Shevchenko wrote:

...

      Fixes: 73345a18d464b ("pinctrl: bcm2835: Pass irqchip when adding
                              gpiochip")

Is it originally so strange indentation or is it only on my side?

The "g" is below the "p" in the patch.

Which is wrong. Tags mustn't be multilines (i.e. split over a single line).

checkpatch disagrees:

I don't care less about checkpatch false positives. You have a chance
to fix it, btw.

I only split it because of checkpatch. What a great tool.

I'll change for V2, which I can submit now if you'll ack it with just that change.

Phil



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux