The 11/30/2021 14:23, Rob Herring wrote:
Hi Rob,
>
> > + items:
> > + - const: switch
> > + - const: phy
> > +
> > + ethernet-ports:
> > + type: object
>
> additionalProperties: false
Yes, I will add then. But then I will need to add also:
properties:
'#address-cells':
const: 1
'#size-cells':
const: 0
>
> > + patternProperties:
> > + "^port@[0-9a-f]+$":
> > + type: object
> > +
> > + allOf:
>
> Don't need allOf here.
>
> > + - $ref: "http://devicetree.org/schemas/net/ethernet-controller.yaml#";
>
> Drop 'http://devicetree.org'. (If you copied that from somewhere, please
> fix them too.)
>
> unevaluatedProperties: false
I will fix this and I would send also a patch for dsa.yaml.
>
> > +
> > + properties:
> > + '#address-cells':
> > + const: 1
> > + '#size-cells':
> > + const: 0
> > +
> > + reg:
> > + description:
> > + Switch port number
> > +
> > + phys:
> > + description:
> > + Phandle of a Ethernet SerDes PHY
> > +
> > + phy-mode:
> > + description:
> > + This specifies the interface used by the Ethernet SerDes towards
> > + the PHY or SFP.
> > + enum:
> > + - gmii
> > + - sgmii
> > + - qsgmii
> > + - 1000base-x
> > + - 2500base-x
> > +
> > + phy-handle:
> > + description:
> > + Phandle of a Ethernet PHY.
> > +
> > + sfp:
> > + description:
> > + Phandle of an SFP.
> > +
> > + managed: true
> > +
> > + required:
> > + - reg
> > + - phys
> > + - phy-mode
> > +
> > + oneOf:
> > + - required:
> > + - phy-handle
> > + - required:
> > + - sfp
> > + - managed
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - reg-names
> > + - interrupts
> > + - interrupt-names
> > + - resets
> > + - reset-names
> > + - ethernet-ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + switch: switch@e0000000 {
> > + compatible = "microchip,lan966x-switch";
> > + reg = <0xe0000000 0x0100000>,
> > + <0xe2000000 0x0800000>;
> > + reg-names = "cpu", "gcb";
> > + interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "xtr";
> > + resets = <&switch_reset 0>, <&phy_reset 0>;
> > + reset-names = "switch", "phy";
> > + ethernet-ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port0: port@0 {
> > + reg = <0>;
> > + phy-handle = <&phy0>;
> > + phys = <&serdes 0 0>;
> > + phy-mode = "gmii";
> > + };
> > +
> > + port1: port@1 {
> > + reg = <1>;
> > + sfp = <&sfp_eth1>;
> > + managed = "in-band-status";
> > + phys = <&serdes 2 4>;
> > + phy-mode = "sgmii";
> > + };
> > + };
> > + };
> > +
> > +...
> > --
> > 2.33.0
> >
> >
--
/Horatiu
