On 08/21/2014 11:59 AM, Murphy, Dan wrote: [...] Ooops.. missed answering one addition statement: >> + of_property_read_u32(np, "ti,palmas-long-press-seconds", &val); > > Probably should check the return to make sure the value exists and that is is > within an expected range. It is an optional parameter and may not exist in dt. when it does exist, the logic tries to do a best match (this is the for loop in the logic just below). -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html