Hi Nishanth, On Thu, Aug 21, 2014 at 11:02:15AM -0500, Nishanth Menon wrote: > + > + ret = input_register_device(input_dev); > + if (ret) { > + free_irq(irq, pwron); You can not use free_irq with devm-managed resources. As I mentioned, since you need manual unwinding, I'd rather you not use managed resources in the driver at all. > + cancel_delayed_work_sync(&pwron->input_work); > + dev_dbg(dev, "Can't register power button: %d\n", ret); > + return ret; Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html