Hi Andrew, Thank you very much for review. I'll move properties nvmem-cells and nvmem-cell-names to ethernet ports and change value of nvmem-cell-names to "mac-address" next patch. I'll refer to "nvmem_get_mac_address()" when modifying code. Best regards, Wells > > + nvmem-cells: > > + items: > > + - description: nvmem cell address of MAC address of 1st MAC > > + - description: nvmem cell address of MAC address of 2nd MAC > > + > > + nvmem-cell-names: > > + description: names corresponding to the nvmem cells of MAC address > > + items: > > + - const: mac_addr0 > > + - const: mac_addr1 > > These are port properties, so put them in the port section. > > Also, the name you should use is well defined, "mac-address". See nvmem_get_mac_address(). > But you won't be able to use that helper because it take dev, not an of node. > > Andrew
