Hi Rob, On Tue, Nov 30 2021, Rob Herring wrote: > On Tue, 30 Nov 2021 19:37:29 +0200, Baruch Siach wrote: >> DT binding for the PWM block in Qualcomm IPQ6018 SoC. >> >> Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx> >> --- >> >> v9: >> >> Add 'ranges' property to example (Rob) >> >> Drop label in example (Rob) >> >> v8: >> >> Add size cell to 'reg' (Rob) >> >> v7: >> >> Use 'reg' instead of 'offset' (Rob) >> >> Drop 'clock-names' and 'assigned-clock*' (Bjorn) >> >> Use single cell address/size in example node (Bjorn) >> >> Move '#pwm-cells' lower in example node (Bjorn) >> >> List 'reg' as required >> >> v6: >> >> Device node is child of TCSR; remove phandle (Rob Herring) >> >> Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König) >> >> v5: Use qcom,pwm-regs for phandle instead of direct regs (Bjorn >> Andersson, Kathiravan T) >> >> v4: Update the binding example node as well (Rob Herring's bot) >> >> v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring) >> >> v2: Make #pwm-cells const (Rob Herring) >> --- >> .../devicetree/bindings/pwm/ipq-pwm.yaml | 53 +++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/pwm/ipq-pwm.example.dt.yaml:0:0: > /example-0/syscon@1937000: failed to match any schema with compatible: > ['qcom,tcsr-ipq6018', 'syscon', 'simple-mfd'] My previous submission[1] had this text above the patch changelog: --- This series does not convert the TCSR binding documentation to YAML. As a result, this commit adds new a dt_binding_check warning: /example-0/syscon@1937000: failed to match any schema with compatible: ['qcom,tcsr-ipq 6018', 'syscon', 'simple-mfd'] If that is a blocker to IPQ6018 PWM support, so be it. Patches will wait for someone else to push them further. --- This time I missed the 'DT_CHECKER_FLAGS=-m' part so I didn't see the error. Thanks for the reminder, baruch [1] https://lore.kernel.org/all/8238dfb5d5e4a40a995f047db36d9a7240431de5.1630323987.git.baruch@xxxxxxxxxx/ > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1561766 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@xxxxxxxxxx - tel: +972.52.368.4656, http://www.tkos.co.il -
