On 26 11月 21 15:14:44, Cai Huoqing wrote: > On 26 11月 21 07:43:34, Greg Kroah-Hartman wrote: > > On Fri, Nov 26, 2021 at 10:18:59AM +0800, Cai Huoqing wrote: > > > ZHOUYI NPU is an AI accelerator chip which is integrated into ARM SOC, > > > such as Allwinner R329 SOC. > > > Add driver support for this AI accelerator here. > > > > > > This driver is not standard linux style, there are some clean up works, > > > fixing code style, refactorring. > > > And it only works with a closed source usermode driver, so need to > > > reverse the libraries, and impelement it, then open source > > > the usermode driver. > > > So add this driver to linux-staging > > > > Sorry, but no, I can not take this driver into the kernel tree until > > there is an open source user of the new api that you are creating with > > this driver. This was discussed many times on the linux-kernel mailing > > list and at the Linux kernel summit a few months ago (see the summary at > > lwn.net about it.) > > > > So please work on that first, and then we will be glad to revisit taking > > this kernel driver into the tree. > OK, I will do that. > And after doing some clean up, try to take this code to the "real" linux tree. > > Thanks, > Cai Recently arm china contact me for some opensource issue. Reply here - Hi arm-china folks, it's appropriate for you to submit this driver for GPL, be glad to revisit the opensource kernel mode and userspace driver:). If you have any questions, reply here directly. Thanks Cai > > > > Also, it is much simpler just to take a few hours and clean up the > > coding style issues yourself rather than relying on the community to do > > it for you over a few months. > > > > thanks, > > > > greg k-h