On Thu, Aug 21, 2014 at 12:19:03PM +0530, sundeep subbaraya wrote: > Hi Daniel, > > On Tue, Aug 19, 2014 at 3:26 PM, Daniel Mack <daniel@xxxxxxxxxx> wrote: > > Hi, > > > > On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote: > >> This patch adds xilinx usb2 device driver support > > > > Add some more information here, please. Copying the text from the > > Kconfig option is already a good start. > > > >> drivers/usb/gadget/Kconfig | 14 + > >> drivers/usb/gadget/Makefile | 1 + > >> drivers/usb/gadget/udc-xilinx.c | 2261 +++++++++++++++++++++++++++++++++++++++ > >> 3 files changed, 2276 insertions(+), 0 deletions(-) > >> create mode 100644 drivers/usb/gadget/udc-xilinx.c > > > > As your driver has a DT binding, you have to describe it in > > Documentation/devicetree/bindings. > > > >> --- a/drivers/usb/gadget/Kconfig > >> +++ b/drivers/usb/gadget/Kconfig > >> @@ -459,6 +459,20 @@ config USB_EG20T > >> ML7213/ML7831 is companion chip for Intel Atom E6xx series. > >> ML7213/ML7831 is completely compatible for Intel EG20T PCH. > >> > >> +config USB_GADGET_XILINX > >> + tristate "Xilinx USB Driver" > >> + depends on COMPILE_TEST > > > > Why would you depend on that? > > Felipe asked to make this since this is USB soft IP driver and its > dependencies have tendency to grow. that's not exactly what I asked :-) Usually you only add COMPILE_TEST when you have an ARCH dependency. So something like: depends on ARCH_ARM || COMPILE_TEST would make it clear that this driver is only available on ARM, but when doing my build tests, I'd still be able to compile it on x86. > > Also, your code uses device tree functions unconditionally, which is > > fine, but it must hence depend on 'OF'. > > Ok will add OF along with COMPILE_TEST so this would be: depends on OF || COMPILE_TEST -- balbi
Attachment:
signature.asc
Description: Digital signature
