Hi Miquel, I love your patch! Perhaps something to improve: [auto build test WARNING on mtd/nand/next] [also build test WARNING on broonie-spi/for-next mtd/mtd/next mtd/mtd/fixes v5.16-rc2 next-20211126] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Miquel-Raynal/External-ECC-engines-Macronix-support/20211126-195956 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next config: xtensa-buildonly-randconfig-r006-20211125 (https://download.01.org/0day-ci/archive/20211127/202111270526.T8x5Nyq1-lkp@xxxxxxxxx/config) compiler: xtensa-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/0804d6ccdf15e7a65743d048d01d876a54070b6b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Miquel-Raynal/External-ECC-engines-Macronix-support/20211126-195956 git checkout 0804d6ccdf15e7a65743d048d01d876a54070b6b # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/spi/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from drivers/spi/spi-mxic.c:16: >> include/linux/mtd/nand-ecc-mxic.h:34:1: warning: no previous prototype for 'mxic_ecc_get_pipelined_engine' [-Wmissing-prototypes] 34 | mxic_ecc_get_pipelined_engine(struct platform_device *spi_pdev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> include/linux/mtd/nand-ecc-mxic.h:39:6: warning: no previous prototype for 'mxic_ecc_put_pipelined_engine' [-Wmissing-prototypes] 39 | void mxic_ecc_put_pipelined_engine(struct nand_ecc_engine *eng) {} | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/mxic_ecc_get_pipelined_engine +34 include/linux/mtd/nand-ecc-mxic.h a19f28121341b52 Miquel Raynal 2021-11-26 32 a19f28121341b52 Miquel Raynal 2021-11-26 33 struct nand_ecc_engine * a19f28121341b52 Miquel Raynal 2021-11-26 @34 mxic_ecc_get_pipelined_engine(struct platform_device *spi_pdev) a19f28121341b52 Miquel Raynal 2021-11-26 35 { a19f28121341b52 Miquel Raynal 2021-11-26 36 return ERR_PTR(-EOPNOTSUPP); a19f28121341b52 Miquel Raynal 2021-11-26 37 } a19f28121341b52 Miquel Raynal 2021-11-26 38 a19f28121341b52 Miquel Raynal 2021-11-26 @39 void mxic_ecc_put_pipelined_engine(struct nand_ecc_engine *eng) {} a19f28121341b52 Miquel Raynal 2021-11-26 40 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
