On Mon 18 Aug 00:16 PDT 2014, Ivan T. Ivanov wrote: > On Sat, 2014-08-16 at 16:24 +0100, Daniel wrote: > > @Ivan: sorry about the double post. > > > > Am 11.08.2014 um 16:40 schrieb Ivan T. Ivanov <iivanov@xxxxxxxxxx>: [...] > > > +#define PMIC_GPIO_PULL_UP_30 1 > > > +#define PMIC_GPIO_PULL_UP_1P5 2 > > > +#define PMIC_GPIO_PULL_UP_31P5 3 > > > +#define PMIC_GPIO_PULL_UP_1P5_30 4 > > > > Looking at drivers/pinctrl/qcom/pinctrl-ssbi-pmic.c, shouldn't these defines start at 0? > > e.g. #define PMIC_GPIO_PULL_UP_30 0 > > > > Initially "bias-pull-up" was used to set this parameter. > Zero value for "bias-pull-up" has special meaning "...the > pin is connected to VDD...". So values in DTS have to have > offset by one. Micro Amps are non-standard for pull-ups, > thats why I have changed this to "qcom,pull-up-strength", but I > have made mistake in config_set function. Following patch should > fix the issue. I will send updated version soon. > The bias-pull-up is read as u32 and 0 means that it's not pull-up, therefor i shifted them all. Sorry about that. Now that we have this in a separate property there's no point in such "trickery" and we should make them follow the register values, i.e: #define PM8XXX_GPIO_BIAS_PU_30 0 #define PM8XXX_GPIO_BIAS_PU_1P5 1 #define PM8XXX_GPIO_BIAS_PU_31P5 2 #define PM8XXX_GPIO_BIAS_PU_1P5_30 3 I find it cleaner and we don't need the translation. > > However, I still cannot get any data from those 2 pins if I export them through /sys/class/gpio... > Reading should work, but most other gpio operations was off by one it seems. I have corrected this (and other reported things) and will send out a new version soon. > - pin->bias = arg - PM8XXX_GPIO_BIAS_PU_30; > + pin->bias = arg - PMIC_GPIO_PULL_UP_30; If we just make it follow the register value (starting at 0) we just use arg straight off. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
