On 25/11/2021 16:31, Geert Uytterhoeven wrote:
> It does not make sense to have an (empty) chosen node in an SoC-specific
> .dtsi, as chosen is meant for system-specific configuration.
> It is already provided in microchip-mpfs-icicle-kit.dts anyway.
>
> Fixes: 0fa6107eca4186ad ("RISC-V: Initial DTS for Microchip ICICLE board")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> index c9f6d205d2ba1a5e..794da883acb19256 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> @@ -9,9 +9,6 @@ / {
> model = "Microchip PolarFire SoC";
> compatible = "microchip,mpfs";
>
> - chosen {
> - };
> -
> cpus {
> #address-cells = <1>;
> #size-cells = <0>;
>
Maybe bootloader expects it? E.g. it looks for node and fills it and
would fail if the node is missing?
Best regards,
Krzysztof
