Hi Felix, thanks for your patch! On Thu, Nov 25, 2021 at 12:24 PM Felix Fietkau <nbd@xxxxxxxx> wrote: > From: John Crispin <john@xxxxxxxxxxx> > > Airoha's GPIO controller on their ARM EN7523 SoCs consists of two banks of 32 > GPIOs > > Signed-off-by: John Crispin <john@xxxxxxxxxxx> (...) > + reg: > + maxItems: 4 Can we write some short description on what the four different regs are? With that fixed: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij