On 20.08.14 18:42, Andy Gross wrote: > On Tue, Aug 19, 2014 at 09:39:30PM -0700, Bjorn Andersson wrote: >> On Tue 19 Aug 10:22 PDT 2014, Georgi Djakov wrote: >> >>> This patch adds support for the TLMM (Top-Level Mode Mux) block found >>> in the APQ8084 platform. >>> >> [...] >>> + >>> +#define NUM_GPIO_PINGROUPS 143 >>> + >> >> I think this looks good overall, but in my APQ8084 documentation >> (80-NG550-2X Rev. B) there are 147 (0..146) gpio pins in the TLMM block. >> >> Any suggestion to why there's a discrepancy? >> > > We have some discrepancies internally on the documentation. However, in this > case I'd expect the OEM documentation to be correct. So this needs to change to > bjorn's version, as it appears to be the correct version. > > I have no idea why some pins are missing. > Thank you for reviewing, Bjorn and Andy. I'll update and submit v2. BR, Georgi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html