Hi Michael, On Wed, Nov 24, 2021 at 05:49:07PM +0100, Michael Tretter wrote: > On Tue, 23 Nov 2021 13:07:00 +0200, Sakari Ailus wrote: > > On Tue, Nov 23, 2021 at 11:15:16AM +0100, Michael Tretter wrote: > > > From: Marek Vasut <marex@xxxxxxx> > > > > > > Add bindings for the Intersil ISL79987 analog to MIPI CSI-2 decoder. > > > > > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > > > Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > > Cc: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx> > > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > > Cc: devicetree@xxxxxxxxxxxxxxx > > > To: linux-media@xxxxxxxxxxxxxxx > > > Signed-off-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx> > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > > --- > > > Changelog: > > > > > > v8: none > > > > > > v7: none > > > > > > v6: none > > > > > > v5: none > > > > > > v4: none > > > > > > v3: > > > > > > - rename pd-gpios property to powerdown-gpios > > > - reference graph.yaml for ports/port properties > > > - remove reference to video-interfaces.txt > > > - remove unnecessary description of ports property > > > > > > v2: > > > > > > - convert binding to yaml > > > - change description to match only isl79987 > > > - replace num-inputs property with multiple ports > > > - add reset gpio > > > --- > > > .../bindings/media/i2c/isil,isl79987.yaml | 100 ++++++++++++++++++ > > > 1 file changed, 100 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml b/Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml > > > new file mode 100644 > > > index 000000000000..aee4a5966df3 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml > > > @@ -0,0 +1,100 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/i2c/isil,isl79987.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Intersil ISL79987 Analog to MIPI CSI-2 decoder > > > + > > > +maintainers: > > > + - Michael Tretter <m.tretter@xxxxxxxxxxxxxx> > > > + - Marek Vasut <marex@xxxxxxx> > > > + > > > +description: > > > + The Intersil ISL79987 is an analog to MIPI CSI-2 decoder which is capable of > > > + receiving up to four analog stream and multiplexing them into up to four MIPI > > > + CSI-2 virtual channels, using one MIPI clock lane and 1/2 data lanes. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - isil,isl79987 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + reset-gpios: > > > + maxItems: 1 > > > + description: > > > + A GPIO spec for the RSTB pin (active high) > > > + > > > + powerdown-gpios: > > > + maxItems: 1 > > > + description: > > > + A GPIO spec for the Power Down pin (active high) > > > + > > > + ports: > > > + $ref: /schemas/graph.yaml#/properties/ports > > > + properties: > > > + port@0: > > > + $ref: /schemas/graph.yaml#/properties/port > > > + description: Output port > > > > I think you need need the data-lanes property for endpoints on this port. > > Thanks. The bot also found that the clock-lanes property is missing, too. > > The following specification seems to satisfy the checker, but I'm not > completely sure, if it is actually correct: > > port@0: > $ref: /schemas/graph.yaml#/$defs/port-base > unevaluatedProperties: false > description: Output port > > properties: > endpoint: > $ref: /schemas/media/video-interfaces.yaml# > unevaluatedProperties: false > > properties: > clock-lanes: > maxItems: 1 > > data-lanes: > minItems: 1 > maxItems: 2 > > required: > - clock-lanes > - data-lanes > > Is this how I can correctly add the clock-lanes and data-lanes properties to > the endpoint? clock-lanes is extra, unless the hardware supports lane remapping. -- Sakari Ailus
