Hi Shimoda-san, Thanks for your patch! On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > Add support for R-Car S4-8 (R8A779F0) SoC power areas and register > access. This register specification is similar with R-Car V3U. similar to > So, introduces rcar-gen4-sysc.c for both V3U and S4-8. introduce. That makes perfect sense, as "the R-Car V3U SoC is based on the R-Car Gen 4 architecture". (https://www.renesas.com/us/en/products/automotive-products/automotive-system-chips-socs/r-car-v3u-best-class-r-car-v3u-asil-d-system-chip-automated-driving) > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > --- a/drivers/soc/renesas/Kconfig > +++ b/drivers/soc/renesas/Kconfig > @@ -359,6 +359,9 @@ config SYSC_R8A77970 > config SYSC_R8A779A0 > bool "System Controller support for R-Car V3U" if COMPILE_TEST > > +config SYSC_R8A779F0 > + bool "System Controller support for R-Car S4-8" if COMPILE_TEST > + Please retain sort order (alphabetically). > config SYSC_RMOBILE > bool "System Controller support for R-Mobile" if COMPILE_TEST > > diff --git a/drivers/soc/renesas/Makefile b/drivers/soc/renesas/Makefile > index 9b29bed2a597..f6c5f8c3818c 100644 > --- a/drivers/soc/renesas/Makefile > +++ b/drivers/soc/renesas/Makefile > @@ -25,11 +25,12 @@ obj-$(CONFIG_SYSC_R8A77980) += r8a77980-sysc.o > obj-$(CONFIG_SYSC_R8A77990) += r8a77990-sysc.o > obj-$(CONFIG_SYSC_R8A77995) += r8a77995-sysc.o > obj-$(CONFIG_SYSC_R8A779A0) += r8a779a0-sysc.o > +obj-$(CONFIG_SYSC_R8A779F0) += r8a779f0-sysc.o > ifdef CONFIG_SMP > obj-$(CONFIG_ARCH_R9A06G032) += r9a06g032-smp.o > endif > > # Family > obj-$(CONFIG_RST_RCAR) += rcar-rst.o > -obj-$(CONFIG_SYSC_RCAR) += rcar-sysc.o > +obj-$(CONFIG_SYSC_RCAR) += rcar-sysc.o rcar-gen4-sysc.o This means all R-Car kernels will always include support for both R-Car Gen1/2/3 and R-Car Gen4. I think this should be split. The rest looks good to me, but I think it wouldn't hurt to split this patch in two parts: one patch to generalize r8a779a0-sysc.c for R-Car Gen4, and a second patch to introduce support for R-Car S4-8. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
