> > + > > + ret = of_property_read_u32(pdev->dev.of_node, > > + "clock-frequency", &bus_rate); > > + if (!ret && (bus_rate <= 100000)) > > + speed = DW_IC_CON_SPEED_STD; > > This looks a bit odd. > > If the device only supports two particular speeds why do we accept any > other speed in the clock-frequency property? "clock-frequency" is the default binding for specifying i2c bus speeds today. Some controllers can be programmed to do various speeds, some can only do a set of fixed values. > Surely we should at least warn that something was off? Yes, I was going to say the same until Romain's old patch showed up which does that. Thanks, Wolfram
Attachment:
signature.asc
Description: Digital signature
