On Tue, Aug 19, 2014 at 05:52:12PM +0200, Philipp Zabel wrote:
> This patch adds support for the HannStar Display Corp. HSD070PWW1 7.0"
> WXGA TFT LCD panel to the simple-panel driver. The binding documentation
> is included.
>
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> ---
> .../bindings/panel/hannstar,hsd070pww1.txt | 7 ++++++
> drivers/gpu/drm/panel/panel-simple.c | 25 ++++++++++++++++++++++
> 2 files changed, 32 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/panel/hannstar,hsd070pww1.txt
>
> diff --git a/Documentation/devicetree/bindings/panel/hannstar,hsd070pww1.txt b/Documentation/devicetree/bindings/panel/hannstar,hsd070pww1.txt
> new file mode 100644
> index 0000000..211c226
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/panel/hannstar,hsd070pww1.txt
> @@ -0,0 +1,7 @@
> +HannStar Display Corp. HSD070PWW1 7.0" WXGA TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "hannstar,hsd070pww1"
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 4ce1db0..ddd651d 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -518,6 +518,28 @@ static const struct panel_desc foxlink_fl500wvr00_a0t = {
> },
> };
>
> +static const struct drm_display_mode hannstar_hsd070pww1_mode = {
> + .clock = 71100,
> + .hdisplay = 1280,
> + .hsync_start = 1280 + 0,
> + .hsync_end = 1280 + 0 + 160,
> + .htotal = 1280 + 0 + 160 + 0,
> + .vdisplay = 800,
> + .vsync_start = 800 + 0,
> + .vsync_end = 800 + 0 + 23,
> + .vtotal = 800 + 0 + 23 + 0,
Horizontal and vertical porches are 0, that doesn't look right.
> + .vrefresh = 60,
> +};
> +
> +static const struct panel_desc hannstar_hsd070pww1 = {
> + .modes = &hannstar_hsd070pww1_mode,
> + .num_modes = 1,
> + .size = {
> + .width = 151,
> + .height = 94,
> + },
> +};
This is missing a value for the .bpc field.
Thierry
Attachment:
pgpgr_eijJVF1.pgp
Description: PGP signature
