Re: [PATCH v2 1/3] pinctrl: qcom: Update lpass variant independent functions as generic

[Srinivasa Rao Mandadapu <srivasam@xxxxxxxxxxxxxx>]

On 11/3/2021 4:52 PM, Srinivas Kandagatla wrote:
Thanks for your time Srini!!!
> Hi Srinivasa,
> Thanks for the patches, I think you forgot to add correct mailing list 
> for this drivers.
>
> Please consider using scripts/get_maintainer.pl to help you with this 
> list.
>
> On 27/10/2021 14:41, Srinivasa Rao Mandadapu wrote:
> > Update pin control variable names to make common for all lpass varients.
> > Update bulk clock voting to optional voting as ADSP bypass platform 
> > doesn't
> > need macro and decodec clocks, these are maintained as power domains and
> > operated from lpass audio core cc.
>
> How are you going to ensure that the powerdomains are switched on when 
> setting up the pinctrl configuration.
>
> Should we not take a reference to the power-domain in this driver?

The required power domains are getting enabled in core-boot level. So no 
need of reference in this driver.

And still if power domain need to referenced, we can do it from device 
tree itself.

> --srini
> > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@xxxxxxxxxxxxxx>
> > Co-developed-by: Venkata Prasad Potturu <potturu@xxxxxxxxxxxxxx>
> > Signed-off-by: Venkata Prasad Potturu <potturu@xxxxxxxxxxxxxx>
> > ---
> >   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 16 ++++++++--------
> >   1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c 
> > b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> > index 2f19ab4..0bd0c16 100644
> > --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> > +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
> > @@ -107,7 +107,7 @@ struct lpi_pinctrl {
> >   };
> >     /* sm8250 variant specific data */
> > -static const struct pinctrl_pin_desc sm8250_lpi_pins[] = {
> > +static const struct pinctrl_pin_desc lpass_lpi_pins[] = {
> >       PINCTRL_PIN(0, "gpio0"),
> >       PINCTRL_PIN(1, "gpio1"),
> >       PINCTRL_PIN(2, "gpio2"),
> > @@ -124,7 +124,7 @@ static const struct pinctrl_pin_desc 
> > sm8250_lpi_pins[] = {
> >       PINCTRL_PIN(13, "gpio13"),
> >   };
> >   -enum sm8250_lpi_functions {
> > +enum lpass_lpi_functions {
> >       LPI_MUX_dmic1_clk,
> >       LPI_MUX_dmic1_data,
> >       LPI_MUX_dmic2_clk,
> > @@ -203,7 +203,7 @@ static const struct lpi_pingroup sm8250_groups[] = {
> >       LPI_PINGROUP(13, NO_SLEW, dmic3_data, i2s2_data, _, _),
> >   };
> >   -static const struct lpi_function sm8250_functions[] = {
> > +static const struct lpi_function lpass_functions[] = {
> >       LPI_FUNCTION(dmic1_clk),
> >       LPI_FUNCTION(dmic1_data),
> >       LPI_FUNCTION(dmic2_clk),
> > @@ -228,12 +228,12 @@ static const struct lpi_function 
> > sm8250_functions[] = {
> >   };
> >     static struct lpi_pinctrl_variant_data sm8250_lpi_data = {
> > -    .pins = sm8250_lpi_pins,
> > -    .npins = ARRAY_SIZE(sm8250_lpi_pins),
> > +    .pins = lpass_lpi_pins,
> > +    .npins = ARRAY_SIZE(lpass_lpi_pins),
> >       .groups = sm8250_groups,
> >       .ngroups = ARRAY_SIZE(sm8250_groups),
> > -    .functions = sm8250_functions,
> > -    .nfunctions = ARRAY_SIZE(sm8250_functions),
> > +    .functions = lpass_functions,
> > +    .nfunctions = ARRAY_SIZE(lpass_functions),
> >   };
> >     static int lpi_gpio_read(struct lpi_pinctrl *state, unsigned int 
> > pin,
> > @@ -615,7 +615,7 @@ static int lpi_pinctrl_probe(struct 
> > platform_device *pdev)
> >           return dev_err_probe(dev, PTR_ERR(pctrl->slew_base),
> >                        "Slew resource not provided\n");
> >   -    ret = devm_clk_bulk_get(dev, MAX_LPI_NUM_CLKS, pctrl->clks);
> > +    ret = devm_clk_bulk_get_optional(dev, MAX_LPI_NUM_CLKS, 
> > pctrl->clks);
> >       if (ret)
> >           return dev_err_probe(dev, ret, "Can't get clocks\n");
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.