Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Friday, November 19, 2021 4:11 AM > > Hi Shimoda-san, > > On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > > Add support for R-Car S4-8 (R8A779F0) to the R-Car RST driver. > > The register map of R-Car S4-8 is the same as R-Car V3U so that > > renames "V3U" and "r8a779a0" with "Gen4". > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > Thanks for your patch! > > > --- a/drivers/soc/renesas/rcar-rst.c > > +++ b/drivers/soc/renesas/rcar-rst.c > > @@ -12,7 +12,7 @@ > > > > #define WDTRSTCR_RESET 0xA55A0002 > > #define WDTRSTCR 0x0054 > > -#define V3U_WDTRSTCR 0x0010 > > +#define GEN4_WDTRSTCR 0x0010 > > V3U_WDTRSTCR handling is not present upstream, as it should be > handled by the boot loader (ATF?), like on other R-Car Gen3 SoCs. > Likewise, GEN4_WDTRSTCR should not become present upstream. I'm sorry. I made this patch on renesas-driver and I didn't realized this V3U_WDTRSTCR handling is not present upstream. > So please split this in two patches: > 1. A patch against upstream, just adding basic R-Car S4-8 support, > 2. An optional second patch to enable GEN4_WDTRSTCR in > renesas-drivers, to serve as an interim solution until the > bootloader is fixed. I got it. I'll make the 1. patch in v2 at this time. Best regards, Yoshihiro Shimoda
