On Mon, 08 Nov 2021 11:01:59 -0800, jae.hyun.yoo@xxxxxxxxx wrote: > From: Jae Hyun Yoo <jae.hyun.yoo@xxxxxxxxxxxxxxx> > > If LPC KCS driver is registered ahead of lpc-ctrl module, LPC KCS > hardware block will be enabled without heart beating of LCLK until > lpc-ctrl enables the LCLK. This issue causes improper handling on > host interrupts when the host sends interrupts in that time frame. > Then kernel eventually forcibly disables the interrupt with > dumping stack and printing a 'nobody cared this irq' message out. > > To prevent this issue, all LPC sub drivers should enable LCLK > individually so this patch adds 'clocks' property as one of > required properties to enable the LCLK by the LPC KCS driver. > > Note: dtsi change in this patch series should be applied along with, > and dtbs should be re-compiled after applying this series since > it's adding a new required property otherwise the driver will not > be probed correctly. > > Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@xxxxxxxxxxxxxxx> > --- > v2 -> v3: > * Made commit message more descriptive. > > v1 -> v2: > Changes sinve v1: > * Added 'clocks' property into kcs-bmc bindings using > 'aspeed,ast2400-kcs-bmc.yaml' because it's not merged into > 'aspeed-lpc.yaml' yet. The bindings merging could be done using a > separate patch later. > > .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
