> > + /* If supported is empty, just copy modes defined in fwnode. */ > > + if (phy_interface_empty(supported)) > > + return phy_interface_copy(supported, modes); > > Doesn't this mean we always end up with the supported_interfaces field > filled in, even for drivers that haven't yet been converted? It will > have the effect of locking the driver to the interface mode in "modes" > where only one interface mode is mentioned in DT. > > At the moment, I think the only drivers that would be affected would be > some DSA drivers, stmmac and macb as they haven't yet been converted. Hi Russell What do you think the best way forward is? Got those converted before merging this? Andrew
