On 18.11.2021 14:57, Andy Shevchenko wrote:
On Thu, Nov 18, 2021 at 3:22 PM Rafał Miłecki <zajec5@xxxxxxxxx> wrote:
...
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
+#include <linux/of.h>
I don't like this. This shows not thought through the design of the series.
What I rather expect is a proper interfacing layer that you fill with
options that can be provided by corresponding underlying
implementation, e.g. DT.
Moreover, before doing this you probably would need to refactor the
pin control core to get rid of DT specifics, i.e. abstract them away
first.
Ouch, it seems like pinctrl got into a tricky state. As I understand it
we need some abstraction layer between DT and pinctrl but noone is
working on it? Does it mean we should consider pinctrl core frozen until
it's refactored?
It's quite inconvenient for me as I'm not sure if I can handle such
heavy pinctrl refactoring while at the same time I'd like to add
those small features to it.
Can you point to an example of extra interfacing layer that could be
used as a reference for what you expect for pinctrl one, please? Some
solution in another Linux's subsystem?
