On 17-11-21, 17:54, Vamsi Krishna Lanka wrote: > On Tue, Nov 16, 2021 at 01:55:29PM +0530, Vinod Koul wrote: > > On 15-11-21, 23:38, quic_vamslank@xxxxxxxxxxx wrote: > > > From: Vamsi Krishna Lanka <quic_vamslank@xxxxxxxxxxx> > > > +{ > > > + struct clk_alpha_pll *pll = to_clk_alpha_pll(hw); > > > + struct regmap *regmap = pll->clkr.regmap; > > > + u32 l, frac; > > > + > > > + regmap_read(regmap, PLL_L_VAL(pll), &l); > > > + l &= LUCID_EVO_PLL_L_VAL_MASK; > > > + regmap_read(regmap, PLL_ALPHA_VAL(pll), &frac); > > > + > > > + return alpha_pll_calc_rate(parent_rate, l, frac, pll_alpha_width(pll)); > > > +} > > > > I think this can use __alpha_pll_trion_set_rate() > > I didn't get with which function are you comparing this. I cannot able to > find any function similar to this. This is in upstream, pls see commit: 80ca7765fc75 ("clk: qcom: clk-alpha-pll: modularize alpha_pll_trion_set_rate()") -- ~Vinod