On 19/08/14 08:55, Viresh Kumar wrote:
> On 19 August 2014 09:03, Tuomas Tynkkynen <tuomas.tynkkynen@xxxxxx> wrote:
>> - use 'select GENERIC_CPUFREQ_CPU0', not depends
>
> Bad :(
>
> It *has* to be a depends here, its not optional. That was outcome of the
> chat we had last time, if I remember it well..
Okay, I misread that conversation then.
>> ---
>
> You don't need to add these --- here, just add a blank line and git
> will take care of things for you :)
There's actually a (mis-?)feature in git format-patch: a literal '---'
line in a commit message won't be escaped, so the patch notes can be
written in the commit message directly so the patch files don't need
to be modified by hand.
>> drivers/cpufreq/Kconfig.arm | 8 ++
>> drivers/cpufreq/Makefile | 1 +
>> drivers/cpufreq/tegra124-cpufreq.c | 206 +++++++++++++++++++++++++++++++++++++
>> 3 files changed, 215 insertions(+)
>> create mode 100644 drivers/cpufreq/tegra124-cpufreq.c
>>
[...]
>> +static int tegra124_cpufreq_probe(struct platform_device *pdev)
>> +{
>
>> + priv->vdd_cpu_reg = regulator_get(get_cpu_device(0), "vdd-cpu");
>
> get_cpu_device() can fail as well, and so you may want to check its return
> value as well..
>
Oh, right.
>> +static int __init tegra_cpufreq_init(void)
>> +{
>> + int ret;
>> + struct platform_device *pdev;
>> +
>> + if (!of_match_machine(soc_of_matches))
>> + return -ENODEV;
>
> You may want to add a comment here on why you chose to add another layer
> of platform device/driver.. i.e. to catch -EPROBE_DEFER from clk-APIs..
>
Yes, a good idea.
--
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
