On Tue, Nov 16, 2021 at 05:00:14PM +0000, Robin Murphy wrote: > On 2021-11-16 15:42, Jean-Philippe Brucker wrote: > > On Tue, Nov 16, 2021 at 12:02:47PM +0000, Robin Murphy wrote: > > > On 2021-11-16 11:35, Jean-Philippe Brucker wrote: > > > > Add devicetree binding for the SMMUv3 PMU, called Performance Monitoring > > > > Counter Group (PMCG) in the spec. Each SMMUv3 implementation can have > > > > multiple independent PMCGs, for example one for the Translation Control > > > > Unit (TCU) and one per Translation Buffer Unit (TBU). > > > > > > > > I previously sent the binding as reply to Jay Chen's thread implementing > > > > device tree support [1]. This posting addresses the comments from that > > > > thread. > > > > > > Ha, I'd also resurrected this and was planning to post it at some point this > > > week[0] - you should have said :) > > > > Ah sorry about that, I just resent because there was some demand for it at > > Linaro > > Heh, no worries - it's not like you were even CC'ed on the thread where I > only mentioned I *might* do it. > > Can I get away with being cheeky and just saying that my review comments are > the diff between my branch and yours, I wonder... Sure, that works for me, I'll send a v2 this week or so Thanks, Jean