On Tue, Nov 16, 2021 at 12:06:36PM +0000, John Garry wrote:
> On 16/11/2021 11:35, Jean-Philippe Brucker wrote:
> > Add device-tree support to the SMMUv3 PMCG. One small cosmetic change
> > while factoring the option mask printout: don't display it when zero, it
> > only contains one erratum at the moment.
> >
> > Signed-off-by: Jay Chen <jkchen@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>
> > ---
> > drivers/perf/arm_smmuv3_pmu.c | 25 +++++++++++++++++++++++--
> > 1 file changed, 23 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c
> > index 226348822ab3..958325ac103a 100644
> > --- a/drivers/perf/arm_smmuv3_pmu.c
> > +++ b/drivers/perf/arm_smmuv3_pmu.c
> > @@ -47,6 +47,7 @@
> > #include <linux/kernel.h>
> > #include <linux/list.h>
> > #include <linux/msi.h>
> > +#include <linux/of.h>
> > #include <linux/perf_event.h>
> > #include <linux/platform_device.h>
> > #include <linux/smp.h>
> > @@ -750,8 +751,15 @@ static void smmu_pmu_get_acpi_options(struct smmu_pmu *smmu_pmu)
> > smmu_pmu->options |= SMMU_PMCG_EVCNTR_RDONLY;
> > break;
> > }
> > +}
> > +
> > +static void smmu_pmu_get_of_options(struct smmu_pmu *smmu_pmu)
> > +{
> > + struct device_node *node = smmu_pmu->dev->of_node;
> > - dev_notice(smmu_pmu->dev, "option mask 0x%x\n", smmu_pmu->options);
> > + if (of_device_is_compatible(node, "hisilicon,smmu-v3-pmcg-hip08"))
>
> I don't think that this is necessary. We don't support DT for hip08, nor
> have any plans to. Incidentally, was this binding missing in your series?
Ok I'll drop this (and the compatible value from patch 1)
Thanks,
Jean
