Hi Rob, On Thu, 11 Nov 2021 at 01:14, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Wed, 10 Nov 2021 16:29:03 +0530, Bhupesh Sharma wrote: > > Convert Qualcomm BAM DMA devicetree binding to YAML. > > > > Cc: Thara Gopinath <thara.gopinath@xxxxxxxxxx> > > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > > --- > > .../devicetree/bindings/dma/qcom_bam_dma.txt | 50 ---------- > > .../devicetree/bindings/dma/qcom_bam_dma.yaml | 91 +++++++++++++++++++ > > 2 files changed, 91 insertions(+), 50 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/dma/qcom_bam_dma.txt > > create mode 100644 Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1553369 > > > dma@12142000: $nodename:0: 'dma@12142000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml > > dma@12182000: $nodename:0: 'dma@12182000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml > arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml > arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml > arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml > arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml > > dma@121c2000: $nodename:0: 'dma@121c2000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml > arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml > arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml > > dma@12402000: $nodename:0: 'dma@12402000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml > arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml > arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml > arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml > arch/arm/boot/dts/qcom-ipq8064-ap148.dt.yaml > arch/arm/boot/dts/qcom-ipq8064-rb3011.dt.yaml > > dma@1dc4000: $nodename:0: 'dma@1dc4000' does not match '^dma-controller(@.*)?$' > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml > > dma@1dc4000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml > > dma@1dc4000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml > > dma@704000: $nodename:0: 'dma@704000' does not match '^dma-controller(@.*)?$' > arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml > arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml > arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml > > dma@704000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: > arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml > arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml > arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml > > dma@7544000: $nodename:0: 'dma@7544000' does not match '^dma-controller(@.*)?$' > arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml > > dma@7584000: $nodename:0: 'dma@7584000' does not match '^dma-controller(@.*)?$' > arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml > arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml > > dma@7884000: $nodename:0: 'dma@7884000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml > > dma@7984000: $nodename:0: 'dma@7984000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml > > dma@8e04000: $nodename:0: 'dma@8e04000' does not match '^dma-controller(@.*)?$' > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac-bit.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-ap120c-ac.dt.yaml > arch/arm/boot/dts/qcom-ipq4018-jalapeno.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c3.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c1.dt.yaml > arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1-c2.dt.yaml > > dma@c184000: $nodename:0: 'dma@c184000' does not match '^dma-controller(@.*)?$' > arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml > arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml > arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml > arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml > arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml > arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml > > dma-controller@17184000: 'iommus' does not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml > > dma-controller@704000: 'qcom,config-pipe-trust-reg' does not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@704000: qcom,controlled-remotely: 'oneOf' conditional failed, one must be fixed: > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@7984000: clock-names:0: 'bam_clk' was expected > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@7984000: clock-names: Additional items are not allowed ('bam_clk' was unexpected) > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@7984000: clock-names: ['iface_clk', 'bam_clk'] is too long > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml > > dma-controller@7984000: clocks: [[9, 138], [9, 137]] is too long > arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml As noted with v4 review as well, all the errors reported above are fixed via other patches in this patchset, for e.g.: [PATCH v5 01/22] arm64: dts: qcom: msm8996: Fix qcom,controlled-remotely property [PATCH v5 02/22] arm64: dts: qcom: msm8996: Fix 'dma' nodes in dts [PATCH v5 04/22] dt-bindings: qcom-bam: Add 'interconnects' & 'interconnect-names' to optional properties [PATCH v5 05/22] dt-bindings: qcom-bam: Add 'iommus' to optional properties Regards, Bhupesh