On Wed, Nov 03, 2021 at 02:49:21PM +0530, Keerthy wrote: > Add VTM bindings documentation. In the Voltage Thermal > Management Module(VTM), K3 J72XX supplies a voltage > reference and a temperature sensor feature that are gathered in the band > gap voltage and temperature sensor (VBGAPTS) module. The band > gap provides current and voltage reference for its internal > circuits and other analog IP blocks. The analog-to-digital > converter (ADC) produces an output value that is proportional > to the silicon temperature. > > Signed-off-by: Keerthy <j-keerthy@xxxxxx> > --- > .../bindings/thermal/ti,j72xx-thermal.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > new file mode 100644 > index 000000000000..8483c495cb9a > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/ti,j72xx-thermal.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/ti,j72xx-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments J72XX VTM (DTS) binding > + > +maintainers: > + - Keerthy <j-keerthy@xxxxxx> > + > +properties: > + compatible: > + const: ti,j721e-vtm > + oneOf: > + - enum: > + - ti,j721e-vtm > + - ti,j7200-vtm Again, this isn't correct. In C like logic, it is saying compatible is (ti,j721e-vtm && (ti,j721e-vtm || ti,j7200-vtm)) which is just 'ti,j721e-vtm'. I think you want just the 'enum'. > + > + reg: > + maxItems: 3 What is each entry? > + > + power-domains: > + maxItems: 1 > + > + "#thermal-sensor-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - power-domains > + - "#thermal-sensor-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/soc/ti,sci_pm_domain.h> > + wkup_vtm0: wkup_vtm0@42040000 { thermal-sensor@... > + compatible = "ti,j721e-vtm"; > + reg = <0x42040000 0x350>, > + <0x42050000 0x350>, > + <0x43000300 0x10>; > + power-domains = <&k3_pds 154 TI_SCI_PD_EXCLUSIVE>; > + #thermal-sensor-cells = <1>; > + }; > + > + mpu_thermal: mpu_thermal { mpu-thermal > + polling-delay-passive = <250>; /* milliseconds */ > + polling-delay = <500>; /* milliseconds */ > + thermal-sensors = <&wkup_vtm0 0>; > + > + trips { > + mpu_crit: mpu_crit { mpu-crit > + temperature = <125000>; /* milliCelsius */ > + hysteresis = <2000>; /* milliCelsius */ > + type = "critical"; > + }; > + }; > + }; > +... > -- > 2.17.1 > >
