On Mon, Aug 18, 2014 at 10:55:12AM -0700, Jacob Pan wrote: > On Sat, 16 Aug 2014 09:53:58 +0300 > Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > > > From: Aaron Lu <aaron.lu@xxxxxxxxx> > > > > Make use of device property API in this driver so that both OF based > > system and ACPI based system can use this driver. > > > Do we always assume OF and ACPI _DSD will have the same property name > strings? i.e. in this patch "gpios" > > + if (device_property_get(dev, "gpios", NULL)) { > > - if (!of_find_property(pp, "gpios", NULL)) { > > Maybe i missed something, but I don't think we can make that assumption > in BIOS. If not, what is the point of having unified interface? We recommend that when it makes sense, the property names in _DSD follow the corresponding DT names. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html