On Thu, 2021-11-11 at 10:13 +0800, Lei Yu wrote: > On Thu, Nov 11, 2021 at 6:29 AM Andrei Kartashev > <a.kartashev@xxxxxxxxx> wrote: > > + > > +&fmc { > > + status = "okay"; > > + flash@0 { > > + status = "okay"; > > + label = "bmc"; > > + m25p,fast-read; > > + partitions { > > + compatible = "fixed-partitions"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + u-boot@0 { > > + reg = <0x0 0x80000>; // 512KB > > + label = "u-boot"; > > + }; > > + > > + fit-image-a@80000 { > > + reg = <0x80000 0x1b80000>; // 27.5MB > > + label = "image-a"; > > + }; > > + > > + sofs@1c00000 { > > + reg = <0x1c00000 0x200000>; // 2MB > > + label = "sofs"; > > + }; > > + > > + rwfs@1e00000 { > > + reg = <0x1e00000 0x600000>; // 6MB > > + label = "rwfs"; > > + }; > > + > > + u-boot-env@2400000 { > > + reg = <0x2400000 0x20000>; // 128KB > > + label = "u-boot-env"; > > + }; > > + > > + fit-image-b@2480000 { > > + reg = <0x2480000 0x1b80000>; // > > 27.5MB > > + label = "image-b"; > > + }; > > + }; > > + }; > > +}; > > The flash layout is not the same as the openbmc static layout, but > like the one used by Intel-BMC. > May I ask if you are going to upstream the bmc-code-update related > changes for this layout? Yeh, we got to this mess, so now it is not easy to change, so we have to deal with Intel-BMC layout. We have our own utility to manage firmware: https://github.com/YADRO-KNS/obmc-yadro-fwupdate What to do with updates through webui, I don't know yet. > > +&i2c0 { > > + /* SMB_IPMB_STBY_LVC3 */ > > + multi-master; > > + general-call; > > + aspeed,dma-buf-size = <4095>; > > + aspeed,hw-timeout-ms = <300>; > > These properties are not available in openbmc linux kernel tree, but > used in Intel-BMC/linux, may I ask if you are going to upstream the > related changes? > Thank you for pointing this, will remove in next revision. > > + status = "okay"; > > +}; > > + > -- Best regards, Andrei Kartashev