On Sat, Nov 6, 2021 at 12:22 AM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote: > > Hi, > > I finally found time to test this. > > On Wed, 3 Nov 2021 21:48:28 +1000 > Alistair Francis <alistair@xxxxxxxxxxxxx> wrote: > > [...] > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + touchscreen@24 { > > + compatible = "cypress,tt2100"; > > + reg = <0x24>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&tp_reset_ds203>; > > + interrupt-parent = <&pio>; > > + interrupts = <1 5 IRQ_TYPE_LEVEL_LOW>; > hmm, in the code is IRQ_TRIGGER_FALLING but here is LEVEL_LOW, hmm what > it is really? The reMarkable uses IRQ_TYPE_EDGE_FALLING, but this example isn't based on that. It' based on the original documentation from the patch series. > > > + reset-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; > > hmm, if the reset gpio at the chip is active low (I guess it is) that > would indicate an inverter between SoC and gpio. So a nonstandard setup > as an example, probably not a good idea. It seems to be common for the cypress,tt2100, as the original documentation and the rM2 both do this. Does the Kobo not do this? Alistair > > Regards, > Andreas