On Tue, Nov 09, 2021 at 03:26:04AM +0100, Ansuel Smith wrote:
> Rename NETDEV trigger enum modes to a more simbolic name and move them
symbolic. Randy is slipping :-)
> in leds.h to make them accessible by any user.
any user? I would be more specific than that. Other triggers dealing
with netdev states?
> +++ b/include/linux/leds.h
> @@ -548,6 +548,13 @@ static inline void *led_get_trigger_data(struct led_classdev *led_cdev)
>
> #endif /* CONFIG_LEDS_TRIGGERS */
>
> +/* Trigger specific enum */
You probably want netdev in the comment above. Things could get
interesting if other ledtrig-*.c started using them.
> +enum led_trigger_netdev_modes {
> + TRIGGER_NETDEV_LINK,
> + TRIGGER_NETDEV_TX,
> + TRIGGER_NETDEV_RX,
> +};
> +
> /* Trigger specific functions */
> #ifdef CONFIG_LEDS_TRIGGER_DISK
> void ledtrig_disk_activity(bool write);
> --
> 2.32.0
>
