On Tue, Nov 09, 2021 at 04:02:57AM +0100, Marek Behún wrote: > On Tue, 9 Nov 2021 03:26:03 +0100 > Ansuel Smith <ansuelsmth@xxxxxxxxx> wrote: > > > Drop NETDEV_LED_MODE_LINKUP from mode list and convert to a simple bool > > that will be true or false based on the carrier link. No functional > > change intended. > > The last time I tried this, I did it for all the fields that are now in > the bitmap, and I was told that the bitmap guarantees atomic access, so > it should be used... > > But why do you needs this? I guess I will see in another patch. > The link_up seems something internal to the netdev trigger and not something strictly related to the blink modes. Why put a status in the mode variable? > Marek -- Ansuel
