Re: [PATCH 1/2] dt-bindings: leds: Document none trigger

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/8/21 6:51 PM, Rob Herring wrote:
On Sun, Oct 24, 2021 at 08:05:55PM +0200, Marek Vasut wrote:
On 10/24/21 10:41 AM, Pavel Machek wrote:
Hi!

There is a trigger called "none" which triggers never, add it to the
list of valid trigger values.

We can do this, but is it useful? If you avoid putting trigger
property, it will do the same thing.

It's not that simple. If you have a DT which specifies a trigger type and a
DTO which overrides that trigger type, then the DTO cannot remove the
trigger from the base DT, it has to set trigger type to "none". So I believe
there is a valid use case for existence of the "none" type.

Sounds like an incorrect partitioning of base and overlays IMO.

Note that you might not have control over the base DT.

There's also already /delete-property/ directive though I'm not sure if
that's supported in overlays.

How do you encode /delete-property/ into the DT overlay blob .dtbo ?
I thought that /delete-property/ and /delete-node/ was a DTC directive and the DT blob has no way to represent either ?



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux