Dear Ansuel, On Mon, 8 Nov 2021 17:46:02 +0100 Ansuel Smith <ansuelsmth@xxxxxxxxx> wrote: > > what is the purpose of adding trigger_offload() methods to LED, if you > > are not going to add support to offload the netdev trigger? That was > > the entire purpose when I wrote that patch. > > But the final step was adding LEDs support for PHY. The idea was to find > a clean way by passing the idea of offloading a trigger... But fact is > that LEDs in PHY operate by themself so it would add overhead selecting > a trigger that will use event/works just to then be ignored as the > trigger is offloaded. I don't understand what kind of overhead in events/works are you talking about. If the trigger is successfully offloaded, there are no events/works. Everything is done in hardware. If you look at my last attempt https://lore.kernel.org/linux-leds/20210601005155.27997-5-kabel@xxxxxxxxxx/ which adds the offloading support to netdev trigger, you can see if (!led_trigger_offload(led_cdev)) return; so if the trigger is succesfully offloaded, the subsequen schedule_delayed_work() is not called and netdev trigger does not do anything. The blinking of the LED on rx/tx activity is done purely in hardware. No software overhead. > Also I think we are missing the fact that most of PHY can operate in > software or in hardware. NOT BOTH. So the entire concept of offloading > some trigger won't work as we were not able to simulate with SW > unsupported trigger. (not the case with netdev as it does only support > link, rx/tx but that was to explain the concept that SW and HW mode are > mutually exclusive.) I am not missing this fact, I know that there are LEDs that cannot be set into purely SW mode. Which brings another problem: Pavel currely isn't convinced that these LEDs should be exported via LED classdev API. We need to persuade him about this, because otherwise we would need to create another subsystem for this. But there are PHYs which do allow purely SW LED control, i.e. I can set the LED to be just ON or OFF. These are for example marvell PHYs. The fact that there are LEDs that can't be controlled purely in SW does not seem a good reason for to not implement it via netdev trigger. Either these LEDs shouldn't be exported as LED classdevs, or they should somehow make use of existing trigger API (so netdev). The fact that the LED cannot be controlled in SW can be simply implemented by refusing to disable the netdev trigger on the LED. > > > > If you just want to create a new trigger that will make the PHY chip do > > the blinking, there is no need at all for the offloading patch. > > > > Again the idea here is that a LED can offer a way to run by HW and then > a trigger configure them and enables the mode. I see the offload and > configure function needed anyway side from the implementation. There is already LED private trigger API for this. You don't need offloading of existing trigger if you are going to create a new trigger anyway. > > And you will also get a NACK from me and also Pavel (LED subsystem > > maintainer). > > > > Can we try to find a common way to introduce this? > > > The current plan is to: > > - add support for offloading existing LED triggers to HW (LED > > controllers (PHY chips, for example)) > > - make netdev trigger try offloading itself to HW via this new API (if > > it fails, netdev trigger will blink the LED in SW as it does now) > > Can't be done. If in HW mode, we should just declare a trigger not > supported in SW if we really want to follow the netdev expanding path. > But still that would mean filling the netdev trigger with extra code and > condition that will only apply in HW mode. At this point just create a > dedicated trigger. The netdev trigger already needs to be expanded with extra code: it doesn't allow indicating different link types, for example. For offloading, the extra code can be quite small. So I don't think this is an argument. > We can consider introducing the same sysfs used by netdev trigger but > nothing else. Not true. > > - create LED classdevices in a PHY driver that have the offload() > > methods implemented. The offload method looks at what trigger is > > being enabled for the LED, and it if it is a netdev trigger with such > > settings that are possible to offload, it will be offloaded. > > > > This whole thing makes use of the existing sysfs ABI. > > So for example if I do > > cd /sys/class/net/eth0/phydev/leds/<LED> > > echo netdev >trigger > > echo eth0 >device_name > > How would this work in HW mode? The PHY blink only with packet in his > port. We can't tell the PHY to HW blink based on an interface. > That is the main problem by using netdev for PHYs, netdev is flexible > but an offload trigger is not and would work only based on some > condition. We should hardcode the device_name in HW and again pollute > the netdev trigger more. netdev trigger does not need to be poluted by this much. All this can be implemented by one callback to offload method, and everything else can be done in the LED driver itself. > An idea would be add tons of check to netdev on every event to check the > interface but that wouldn't go against any offload idea? The system will > be loaded anyway with all these checks. The checks are done only at the moment of configuring the trigger. Surely you don't see that as "loaded system". > > > echo 1 >rx > > echo 1 >tx > > The netdev trigger is activated, and it calls the offload() method. > > The offload() method is implemented in the PHY driver, and it checks > > that it can offload these settings (blink on rx/tx), and will enable > > this. > > - extend netdev trigger to support more settings: > > - indicate link for specific link modes only (for example 1g, 100m) > > - ... > > - extend PHY drivers to support offloading of these new settings > > > > Marek > > The rest of the implementation is very similar. Except we just NOT use > netdev. And to me it does seems the most sane way to handle offload for > a LED. (considering the specific situation of a PHY) > > From what I can see we have 2 path: > - Pollute netdev trigger to add entire different function for HW. (that > will end up in complex condition and more load/overhead) > - Introduce a new way to entirely offload some triggers. The check conditions would be all in LED driver (PHY driver in this case). The code could be a little complicated, but it only needs to be written once, and the PHY drivers can reuse it. netdev trigger is not polluted, only a few calls to offload() method are done. > Could be that here I'm just using the wrong word and I should use > hardware instead offload. But considering we are offloading some trigger > (example rx/tx/link) it's not that wrong. > > The thing is why trying to expand a trigger that will just remove some > flexibility when we can solve the problem at the source with some > additional API that currently we lack any support (leds can be > configured to run by hw) and some dedicated trigger that will do the > task in a cleaner way (and without adding extra load/overhead by really > offloading the task) ? As I explained above, there is no extra load/overhead. The only thing that is extra is that netdev trigger gets a little more new code, but that is already needed anyway. > > Again hope I didn't seem rude in this message but I just want to find a > solution and proposing a new idea/explaining my concern. > I don't think you're rude, we are just discussing a topic for which we have different opinions. Marek
