On Wed, Oct 27, 2021 at 6:34 PM Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > Hi Adam, > > Thank you for the patch. > > On Sat, Oct 23, 2021 at 03:34:56PM -0500, Adam Ford wrote: > > The schematic shows support for a camera interface, and the NXP > > kernel shows it is an OV5640. > > The camera is an external module though. Should this be a DT overlay ? > Laurent, I wanted to ask you about your comment here. I would agree that for something like the OV5640 on the imx8mm-evk which is an add-in board via a connector should be a dt overlay. I'm investigating using overlays for features like this on my boards vs creating hierarchical dts files and I see that the kernel allows building fragments with '/plugin/' but I don't see any such overlays in the kernel tree currently. Would overlay/fragments be accepted? Are there any examples in the kernel tree already that I'm missing? Best regards, Tim