On Tue, Nov 2, 2021 at 8:31 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Tue, Nov 2, 2021 at 6:57 PM Robert Marko <robert.marko@xxxxxxxxxx> wrote: > > > > Delta TN48M CPLD exposes resets for the following: > > * 88F7040 SoC > > * 88F6820 SoC > > * 98DX3265 switch MAC-s > > * 88E1680 PHY-s > > * 88E1512 PHY > > * PoE PSE controller > > > > Controller supports only self clearing resets. > > ... > > > +#include <linux/device.h> > > +#include <linux/kernel.h> > > +#include <linux/module.h> > > > +#include <linux/of.h> > > I haven't found any user of this header, but mod_devicetable.h is missing. Hi, thanks will fix up in v8. > > > +#include <linux/platform_device.h> > > +#include <linux/regmap.h> > > +#include <linux/reset-controller.h> > > > +#include <dt-bindings/reset/delta,tn48m-reset.h> > > Shouldn't this go before linux/* as it provides more generic definitions? I have looked at other drivers and I would say that almost all of them do it this way, putting it after other includes. I also personally prefer it this way. > > ... > > > +#define TN48M_RESET_TIMEOUT 125000 > > +#define TN48M_RESET_SLEEP 10 > > In which units? (both) Its microseconds, will make it clear in v8. Regards, Robert > > -- > With Best Regards, > Andy Shevchenko -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@xxxxxxxxxx Web: www.sartura.hr
