RE: [PATCHv3 3/3] pwm: documentation: Add 'big-endian' property for FTM PWM.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




[...]
>>  Freescale FlexTimer Module (FTM) PWM controller
>>
>> +For the same FTM PWM device, which on different SoCs will in
>> +differrent endian mode, using the same linux device driver need
>> +one boolean properties to distingush this.
>
> There is absolutely no need to mention Linux if this is truly a HW
> property.

Okay.

[...]
>> +
>> +For now the FTM PWM is only applied to the ARM SoCs which are all
>> +in LE mode.
>> +
>> +So the DT binding for FTM PWM device endian:
>> +SoC     |  FTM-PWM | 'big-endian' property is needed?
>> +--------|----------|---------------------------------
>> +Vybird  |    LE    |     No
>> +LS1     |    BE    |     Yes
>> +LS2     |    LE    |     No
>> +
>> +Please see "Documentation/devicetree/bindings/regmap/regmap.txt" for more
>> +detail about the endianness.
>
> Surely all we need is:
>
> The FTM PWM device can be integrated as little-endian or big-endian.
> This endianness differs per SoC:
>
> SoC     | FTM-PWM endianness
> --------+-------------------
> Vybrid  | LE
> LS1     | BE
> LS2     | LE

I'll follow your advice.

[...]
>> +- big-endian: One boolean property, for all the device registers, the BE mode
>> +  will be in use if it's present, or the LE mode will be in use.
>
>- big-endian: Boolean property, required if all the FTM_PWM registers
>  are big-endian rather than little-endian.
>

See the next version.

Thanks very much for you comment and advice.

BRs
XIubo



> Cheers,
> Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux