Re: [PATCH v2 4/8] reset: Add Sunplus SP7021 reset driver

[kernel test robot <lkp@xxxxxxxxx>]

Hi Qin,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on pza/reset/next clk/clk-next tip/irq/core linus/master v5.15-rc7 next-20211029]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Qin-Jian/Add-Sunplus-SP7021-SoC-Support/20211029-171054
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/45fff7c04fb4d0ccfbd1ed11f73277d1f8742499
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Qin-Jian/Add-Sunplus-SP7021-SoC-Support/20211029-171054
        git checkout 45fff7c04fb4d0ccfbd1ed11f73277d1f8742499
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/reset/reset-sunplus.c: In function 'sp_restart':
>> drivers/reset/reset-sunplus.c:98:42: error: 'RST_SYSTEM' undeclared (first use in this function)
      98 |         sp_reset_assert(&sp_reset.rcdev, RST_SYSTEM);
         |                                          ^~~~~~~~~~
   drivers/reset/reset-sunplus.c:98:42: note: each undeclared identifier is reported only once for each function it appears in
   drivers/reset/reset-sunplus.c: In function 'sp_reset_probe':
>> drivers/reset/reset-sunplus.c:135:33: error: 'RST_MAX' undeclared (first use in this function); did you mean 'S8_MAX'?
     135 |         data->rcdev.nr_resets = RST_MAX;
         |                                 ^~~~~~~
         |                                 S8_MAX


vim +/RST_SYSTEM +98 drivers/reset/reset-sunplus.c

    94	
    95	static int sp_restart(struct notifier_block *this, unsigned long mode,
    96					void *cmd)
    97	{
  > 98		sp_reset_assert(&sp_reset.rcdev, RST_SYSTEM);
    99		sp_reset_deassert(&sp_reset.rcdev, RST_SYSTEM);
   100	
   101		return NOTIFY_DONE;
   102	}
   103	
   104	static struct notifier_block sp_restart_nb = {
   105		.notifier_call = sp_restart,
   106		.priority = 192,
   107	};
   108	
   109	static const struct reset_control_ops sp_reset_ops = {
   110		.assert		= sp_reset_assert,
   111		.deassert	= sp_reset_deassert,
   112		.status		= sp_reset_status,
   113	};
   114	
   115	static const struct of_device_id sp_reset_dt_ids[] = {
   116		{ .compatible = "sunplus,sp7021-reset", },
   117		{ .compatible = "sunplus,q645-reset", },
   118		{ /* sentinel */ },
   119	};
   120	
   121	static int sp_reset_probe(struct platform_device *pdev)
   122	{
   123		struct device *dev = &pdev->dev;
   124		struct sp_reset_data *data = &sp_reset;
   125		void __iomem *membase;
   126		struct resource *res;
   127	
   128		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
   129		membase = devm_ioremap(dev, res->start, resource_size(res));
   130		if (IS_ERR(membase))
   131			return PTR_ERR(membase);
   132	
   133		data->membase = membase;
   134		data->rcdev.owner = THIS_MODULE;
 > 135		data->rcdev.nr_resets = RST_MAX;
   136		data->rcdev.ops = &sp_reset_ops;
   137		data->rcdev.of_node = dev->of_node;
   138		register_restart_handler(&sp_restart_nb);
   139	
   140		return devm_reset_controller_register(dev, &data->rcdev);
   141	}
   142	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip