On Fri, 29 Oct 2021 10:52:53 +0530 Prasanna Vengateshan wrote: > Reused the KSZ common APIs for get_ethtool_stats() & get_sset_count() > along with relevant lan937x hooks for KSZ common layer and added > support for get_strings() > > Signed-off-by: Prasanna Vengateshan <prasanna.vengateshan@xxxxxxxxxxxxx> > static void lan937x_port_stp_state_set(struct dsa_switch *ds, int port, > u8 state) > { > @@ -426,6 +441,9 @@ const struct dsa_switch_ops lan937x_switch_ops = { > .phy_read = lan937x_phy_read16, > .phy_write = lan937x_phy_write16, > .port_enable = ksz_enable_port, > + .get_strings = lan937x_get_strings, > + .get_ethtool_stats = ksz_get_ethtool_stats, > + .get_sset_count = ksz_sset_count, > .port_bridge_join = ksz_port_bridge_join, > .port_bridge_leave = ksz_port_bridge_leave, > .port_stp_state_set = lan937x_port_stp_state_set, Recent commit 487d3855b641 ("net: dsa: allow reporting of standard ethtool stats for slave devices") plumbed thru all the standard stats ops. You must report standard stats (get_eth_*_stats and get_stats64) before implementing get_ethtool_stats.