Re: [PATCH V2 3/3] thermal: qcom: add support for PMIC5 Gen2 ADCTM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jishnu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on jic23-iio/togreg robh/for-next v5.15-rc7]
[cannot apply to next-20211027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jishnu-Prakash/thermal-qcom-Add-support-for-PMIC5-Gen2-ADC_TM/20211027-000845
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/90d78f22dbc7aaa34c78d2bc474aaaf9a6580c4b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jishnu-Prakash/thermal-qcom-Add-support-for-PMIC5-Gen2-ADC_TM/20211027-000845
        git checkout 90d78f22dbc7aaa34c78d2bc474aaaf9a6580c4b
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/thermal/qcom/qcom-spmi-adc-tm5.c: In function 'adc_tm5_init':
>> drivers/thermal/qcom/qcom-spmi-adc-tm5.c:713:20: error: 'data' undeclared (first use in this function); did you mean '_data'?
     713 |         if (chip-->data->gen == ADC_TM5_GEN2) {
         |                    ^~~~
         |                    _data
   drivers/thermal/qcom/qcom-spmi-adc-tm5.c:713:20: note: each undeclared identifier is reported only once for each function it appears in


vim +713 drivers/thermal/qcom/qcom-spmi-adc-tm5.c

   692	
   693	static int adc_tm5_init(struct adc_tm5_chip *chip)
   694	{
   695		u8 buf[4], channels_available;
   696		int ret;
   697		unsigned int i;
   698	
   699		ret = adc_tm5_read(chip, ADC_TM5_NUM_BTM,
   700				   &channels_available, sizeof(channels_available));
   701		if (ret) {
   702			dev_err(chip->dev, "read failed for BTM channels\n");
   703			return ret;
   704		}
   705	
   706		for (i = 0; i < chip->nchannels; i++) {
   707			if (chip->channels[i].channel >= channels_available) {
   708				dev_err(chip->dev, "Invalid channel %d\n", chip->channels[i].channel);
   709				return -EINVAL;
   710			}
   711		}
   712	
 > 713		if (chip-->data->gen == ADC_TM5_GEN2) {
   714			mutex_init(&chip->adc_mutex_lock);
   715			return ret;
   716		}
   717	
   718		buf[0] = chip->decimation;
   719		buf[1] = chip->avg_samples | ADC_TM5_FAST_AVG_EN;
   720		buf[2] = ADC_TM5_TIMER1;
   721		buf[3] = FIELD_PREP(ADC_TM5_MEAS_INTERVAL_CTL2_MASK, ADC_TM5_TIMER2) |
   722			 FIELD_PREP(ADC_TM5_MEAS_INTERVAL_CTL3_MASK, ADC_TM5_TIMER3);
   723	
   724		ret = adc_tm5_write(chip, ADC_TM5_ADC_DIG_PARAM, buf, sizeof(buf));
   725		if (ret) {
   726			dev_err(chip->dev, "block write failed: %d\n", ret);
   727			return ret;
   728		}
   729	
   730		return ret;
   731	}
   732	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux