On 10/27/21 3:22 PM, Guenter Roeck wrote: > On Wed, Oct 27, 2021 at 11:55:31PM +0200, Rafał Miłecki wrote: >> From: Rafał Miłecki <rafal@xxxxxxxxxx> >> >> So far bcm63xx_wdt included support for Broadcom's watchdog block of old >> MIPS devices only. It was also a fully platform (non-DT) driver. >> >> The same block was recently found on BCM4908 with just a slightly >> different registers layout. Extend this driver to support OF and add >> support for per-chipset registers offsets. >> >> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> > > Please convert the driver to use the watchdog subsystem first. > Also, when doing so, please explain why you don't use the bcm7038 > driver instead, since it serves the same hardware interface and > already supports the watchdog core. This is too ugly unfortunately so yes let us use bcm7038_wdt.c and let me know if you need help with converting arch/mips/bcm63xx to use the bcm7038_wdt.c -- Florian
