On Tue, Oct 26, 2021 at 05:54:03PM -0700, Stephen Boyd wrote: > Quoting Emil Renner Berthing (2021-10-26 15:35:36) > > On Tue, 26 Oct 2021 at 22:20, Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > > Quoting Emil Renner Berthing (2021-10-21 10:42:13) ... > > > > +static int __init clk_starfive_jh7100_probe(struct platform_device *pdev) > > > > > > Drop __init as this can be called after kernel init is over. > > > > Oh interesting, I'd like to know when that can happen. The comment for > > the builtin_platform_driver macro says it's just a wrapper for > > I thought this was using module_platform_driver() macro? > > > device_initcall. > > > > Won't we then need to remove all the __initconst tags too since the > > probe function walks through jh7100_clk_data which eventually > > references all __initconst data? > > Yes. If it's builtin_platform_driver() it can't be a module/tristate > Kconfig, in which case all the init markings can stay. What about bind/unbind attribute? -- With Best Regards, Andy Shevchenko
