Re: [PATCH v7 3/3] media: i2c: isl7998x: Add driver for Intersil ISL7998x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

I love your patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on robh/for-next linus/master v5.15-rc7 next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Michael-Tretter/media-i2c-isl7998x-Add-driver-for-Intersil-ISL7998x/20211022-000354
base:   git://linuxtv.org/media_tree.git master
config: riscv-randconfig-r005-20211025 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a461fa64bb37cffd73f683c74f6b0780379fc2ca)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/0day-ci/linux/commit/014607ac2112aed988e4b5c715585fbc9f143d80
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Michael-Tretter/media-i2c-isl7998x-Add-driver-for-Intersil-ISL7998x/20211022-000354
        git checkout 014607ac2112aed988e4b5c715585fbc9f143d80
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/media/i2c/isl7998x.c:520:8: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
   static const unsigned int isl7998x_norm_to_val(v4l2_std_id norm)
          ^~~~~~
   1 warning generated.


vim +/const +520 drivers/media/i2c/isl7998x.c

   519	
 > 520	static const unsigned int isl7998x_norm_to_val(v4l2_std_id norm)
   521	{
   522		unsigned int i;
   523	
   524		for (i = 0; i < ARRAY_SIZE(isl7998x_std_res); i++)
   525			if (isl7998x_std_res[i].norm & norm)
   526				return isl7998x_std_res[i].id;
   527	
   528		return 7;
   529	}
   530	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux