On 25/10/2021 18.41, Joey Gouly wrote:
Hi,
On Mon, Oct 25, 2021 at 06:07:35PM +0900, Hector Martin wrote:
On 24/10/2021 19.18, Joey Gouly wrote:
This driver adds support for the pinctrl / GPIO hardware found
on some Apple SoCs.
Co-developed-by: Stan Skowronek <stan@xxxxxxxxxxxxx>
Signed-off-by: Stan Skowronek <stan@xxxxxxxxxxxxx>
Signed-off-by: Joey Gouly <joey.gouly@xxxxxxx>
---
[snip]
+/* GPIO chip functions */
+
+static int apple_gpio_gpio_get_direction(struct gpio_chip *chip,
+ unsigned int offset)
Nit: do we really need to gpio_gpio all the things? I think maz already
mentioned this one.
I forgot to reply to that. The reason (perhaps not a good one), is that the
module is called 'apple_gpio' and these set of functions are related to the
GPIO interface (not the pinctrl side of things). I'm not tied to the names
either way.
I figured that would be it. Personally I'd just consider the second
"gpio" implicit here and drop it, but that's me; you can do it however
you want :)
--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub
