On Thu, 2021-10-21 at 15:05 +0300, amirmizi6@xxxxxxxxx wrote: > From: Amir Mizinski <amirmizi6@xxxxxxxxx> > > tpm_tis_req_canceled() function is used to check if the caller requested > to abort the current operation. It was found that in some cases > tpm_tis_req_canceled() wrongly returned true. > Since a cancel request sets the TPM_STS.commandReady field to TRUE, the > tpm_tis_req_canceled() function should check only the TPM_STS.commandReady > field value. > The case for TPM_VID_WINBOND is wrong and was therefore removed. > > Also, the default comparison is wrong. Only cmdReady bit needs to be > compared instead of the full lower status register byte. > > Fixes: 1f866057291f (tpm: Fix cancellation of TPM commands (polling mode)) Please go through the comments for 1/6 and fix the commit for the rest of the patches. /Jarkko
