Hi Dikshita, On 9/22/21 1:15 AM, Bjorn Andersson wrote: > On Mon 20 Sep 23:50 CDT 2021, Dikshita Agarwal wrote: > >> Add DT entries for the sc7280 venus encoder/decoder. >> >> this patch depends on [1]. >> >> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=529463 Please drop those two lines above. > > The stuff you write here will be forever imprinted in the git history > and it's already unnecessary, given that the patch you reference here is > available in linux-next. > > Things you want to mention, but shouldn't go into the git history, put > those below the '---' line. > >> >> Co-developed-by: Mansur Alisha Shaik <mansur@xxxxxxxxxxxxxx> >> Signed-off-by: Dikshita Agarwal <dikshita@xxxxxxxxxxxxxx> >> Signed-off-by: Mansur Alisha Shaik <mansur@xxxxxxxxxxxxxx> I guess this should be : Co-developed-by: Mansur Alisha Shaik <mansur@xxxxxxxxxxxxxx> Signed-off-by: Mansur Alisha Shaik <mansur@xxxxxxxxxxxxxx> Signed-off-by: Dikshita Agarwal <dikshita@xxxxxxxxxxxxxx> but checkpatch --strict should complain about this, no? >> --- >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 75 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 75 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index a8c274a..f171ababc 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> @@ -63,6 +63,11 @@ >> no-map; >> reg = <0x0 0x80b00000 0x0 0x100000>; >> }; >> + >> + video_mem: memory@8b200000 { >> + reg = <0x0 0x8b200000 0x0 0x500000>; >> + no-map; >> + }; >> }; >> >> cpus { >> @@ -1063,6 +1068,76 @@ >> qcom,bcm-voters = <&apps_bcm_voter>; >> }; >> >> + venus: video-codec@aa00000 { >> + compatible = "qcom,sc7280-venus"; > > I do however now see this compatible defined in a binding in linux-next, > so you definitely should have listed that patch as a dependency - and > preferably held off sending me 6 versions (plus resend) of a patch that > I can't merge. > > Please ping me once the binding is merged, so that I know when I can > merge this patch. Bjorn, the binding is in linux-next now. -- -- regards, Stan
