On 20-10-21, 09:46, Rob Herring wrote: > On Wed, Oct 20, 2021 at 02:19:05AM +0300, Dmitry Osipenko wrote: > > Not all OPP table names and OPP entries consist of a single word. In > > particular NVIDIA Tegra OPP tables use multi-word names. Allow OPP node > > and OPP entry name to have multi-worded names to silence DT checker > > warnings about the multi-word names separated by hyphen. > > > > Reviewed-by: David Heidelberg <david@xxxxxxx> > > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > > --- > > Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > > index ae3ae4d39843..298cf24af270 100644 > > --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > > +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml > > @@ -22,7 +22,7 @@ select: false > > > > properties: > > $nodename: > > - pattern: '^opp-table(-[a-z0-9]+)?$' > > + pattern: '^opp-table(-[a-z0-9]+)*$' > > I don't see how this helps you. What I see needed upstream is a prefix: > > '-?opp-table(-[0-9]+)?$' I wonder if we should disallow that to keep naming more consistent. > Though really what I'd like to see is the OPP nodes moved into the > device nodes they belong to when appropriate (i.e. when not shared > between multiple devices). +1 The only reason for keeping it outside was because CPUs were sharing them. -- viresh
