Hi Mark, On 8/15/14, 6:27 AM, Mark Rutland wrote: > Hi Dinh, > > On Thu, Aug 14, 2014 at 10:13:34PM +0100, dinguyen@xxxxxxxxxxxxxxxxxxxxx wrote: >> From: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx> >> >> The SOCFPGA's SMP code uses 0x0 for as the location for the trampoline to >> bring secondary cores online. This patch adds a /memreserve/ section to >> reserve the first 4K for the SMP trampoline code. > > I'm slightly confused. > > Sorry to split hairs here, but I think the comment is subtly wrong. > > The trampoline code seems to be placed in this location by Linux, so > it's not that we're protecting the trampoline code, but rather we're > preserving the location for future use. Yes, you're correct. Preserving this location for possible copying of the trampoline code for SMP usage is more of a correct statement. > > I take it that the reset address isn't configurable? No, I don't believe it is on this platform. Thanks for the review. I will spin a V3 with an updated commit message. Dinh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
